fix(database): don't emit UNSIGNED on Postgres - #2295
Open
osbre wants to merge 2 commits into
Open
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 7047100 |
osbre
marked this pull request as draft
September 12, 2026 04:39
osbre
marked this pull request as ready for review
September 12, 2026 04:44
brendt
requested changes
Sep 13, 2026
osbre
force-pushed
the
fix/database-unsigned-postgres
branch
from
September 13, 2026 12:11
270ed07 to
1d95d5d
Compare
osbre
force-pushed
the
fix/database-unsigned-postgres
branch
from
September 13, 2026 15:06
1d95d5d to
7047100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where using
unsigned: trueon an integer column breaks Postgres migrations with asyntax error at or near "UNSIGNED".Postgres doesn't support unsigned integer types, so it now gets the plain integer type instead. MySQL and SQLite are unchanged. Added missing unit tests for
unsignedcolumns to CI so Postgres doesn't break again.